From 47c270d040d03d0e8cdd300f33743c758ce79dd1 Mon Sep 17 00:00:00 2001 From: Taylor R Campbell Date: Thu, 31 Mar 2022 02:37:01 +0000 Subject: [PATCH 32/49] rumpkern/scheduler: Use membar_release. ...but add an XXX comment asking for clarity on what it pairs with. --- sys/rump/librump/rumpkern/scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/rump/librump/rumpkern/scheduler.c b/sys/rump/librump/rumpkern/scheduler.c index 12dfde2f1765..577d6ea4986e 100644 --- a/sys/rump/librump/rumpkern/scheduler.c +++ b/sys/rump/librump/rumpkern/scheduler.c @@ -473,7 +473,7 @@ rump_unschedule_cpu1(struct lwp *l, void *interlock) if (interlock == rcpu->rcpu_mtx) rumpuser_mutex_enter_nowrap(rcpu->rcpu_mtx); else - membar_exit(); + membar_release(); /* XXX what does this pair with? */ /* Release the CPU. */ old = atomic_swap_ptr(&rcpu->rcpu_prevlwp, l);