From 7f3c5830e59603099bdd8d6077bc10c9b484301d Mon Sep 17 00:00:00 2001 From: Taylor R Campbell Date: Mon, 31 Jan 2022 01:22:08 +0000 Subject: [PATCH 32/36] specfs: Assert opencnt is nonzero before decrementing. --- sys/miscfs/specfs/spec_vnops.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/miscfs/specfs/spec_vnops.c b/sys/miscfs/specfs/spec_vnops.c index 279fe4a8991f..74c053c011ae 100644 --- a/sys/miscfs/specfs/spec_vnops.c +++ b/sys/miscfs/specfs/spec_vnops.c @@ -894,6 +894,8 @@ spec_open(void *v) KASSERT(sn->sn_opencnt == 1); needclose = true; } else { + KASSERT(sd->sd_opencnt); + KASSERT(sn->sn_opencnt); sd->sd_opencnt--; sn->sn_opencnt--; if (vp->v_type == VBLK) @@ -1597,6 +1599,8 @@ spec_close(void *v) * between open and close can use fd_clone. */ mutex_enter(&device_lock); + KASSERT(sn->sn_opencnt); + KASSERT(sd->sd_opencnt); sn->sn_opencnt--; count = --sd->sd_opencnt; if (vp->v_type == VBLK) {