Index: kern/vfs_syscalls.c =================================================================== RCS file: /cvsroot/src/sys/kern/vfs_syscalls.c,v retrieving revision 1.450 diff -u -p -u -r1.450 vfs_syscalls.c --- kern/vfs_syscalls.c 13 Mar 2012 18:40:56 -0000 1.450 +++ kern/vfs_syscalls.c 17 Apr 2012 19:08:31 -0000 @@ -3360,15 +3360,13 @@ change_owner(struct vnode *vp, uid_t uid * group-id settings intact in that case. */ if (vattr.va_mode & S_ISUID) { - error = kauth_authorize_vnode(l->l_cred, - KAUTH_VNODE_RETAIN_SUID, vp, NULL, EPERM); - if (error) + if (kauth_authorize_vnode(l->l_cred, + KAUTH_VNODE_RETAIN_SUID, vp, NULL, EPERM) != 0) newmode &= ~S_ISUID; } if (vattr.va_mode & S_ISGID) { - error = kauth_authorize_vnode(l->l_cred, - KAUTH_VNODE_RETAIN_SGID, vp, NULL, EPERM); - if (error) + if (kauth_authorize_vnode(l->l_cred, + KAUTH_VNODE_RETAIN_SGID, vp, NULL, EPERM) != 0) newmode &= ~S_ISGID; } } else { Index: ufs/chfs/chfs_vnops.c =================================================================== RCS file: /cvsroot/src/sys/ufs/chfs/chfs_vnops.c,v retrieving revision 1.4 diff -u -p -u -r1.4 chfs_vnops.c --- ufs/chfs/chfs_vnops.c 12 Apr 2012 15:31:01 -0000 1.4 +++ ufs/chfs/chfs_vnops.c 17 Apr 2012 19:08:32 -0000 @@ -969,16 +969,14 @@ out: ip->iflag |= IN_CHANGE | IN_UPDATE; if (resid > uio->uio_resid && ap->a_cred) { if (ip->mode & ISUID) { - error = kauth_authorize_vnode(ap->a_cred, KAUTH_VNODE_RETAIN_SUID, vp, - NULL, EPERM); - if (error) + if (kauth_authorize_vnode(ap->a_cred, + KAUTH_VNODE_RETAIN_SUID, vp, NULL, EPERM) != 0) ip->mode &= ~ISUID; } if (ip->mode & ISGID) { - error = kauth_authorize_vnode(ap->a_cred, KAUTH_VNODE_RETAIN_SGID, vp, - NULL, EPERM); - if (error) + if (kauth_authorize_vnode(ap->a_cred, + KAUTH_VNODE_RETAIN_SGID, vp, NULL, EPERM) != 0) ip->mode &= ~ISGID; } } Index: ufs/ext2fs/ext2fs_readwrite.c =================================================================== RCS file: /cvsroot/src/sys/ufs/ext2fs/ext2fs_readwrite.c,v retrieving revision 1.59 diff -u -p -u -r1.59 ext2fs_readwrite.c --- ufs/ext2fs/ext2fs_readwrite.c 13 Mar 2012 18:41:03 -0000 1.59 +++ ufs/ext2fs/ext2fs_readwrite.c 17 Apr 2012 19:08:32 -0000 @@ -378,16 +378,14 @@ out: ip->i_flag |= IN_ACCESS; if (resid > uio->uio_resid && ap->a_cred) { if (ip->i_e2fs_mode & ISUID) { - error = kauth_authorize_vnode(ap->a_cred, KAUTH_VNODE_RETAIN_SUID, vp, - NULL, EPERM); - if (error) + if (kauth_authorize_vnode(ap->a_cred, + KAUTH_VNODE_RETAIN_SUID, vp, NULL, EPERM) != 0) ip->i_e2fs_mode &= ISUID; } if (ip->i_e2fs_mode & ISGID) { - error = kauth_authorize_vnode(ap->a_cred, KAUTH_VNODE_RETAIN_SGID, vp, - NULL, EPERM); - if (error) + if (kauth_authorize_vnode(ap->a_cred, + KAUTH_VNODE_RETAIN_SGID, vp, NULL, EPERM) != 0) ip->i_e2fs_mode &= ~ISGID; } } Index: ufs/ufs/ufs_readwrite.c =================================================================== RCS file: /cvsroot/src/sys/ufs/ufs/ufs_readwrite.c,v retrieving revision 1.102 diff -u -p -u -r1.102 ufs_readwrite.c --- ufs/ufs/ufs_readwrite.c 13 Mar 2012 18:41:14 -0000 1.102 +++ ufs/ufs/ufs_readwrite.c 17 Apr 2012 19:08:32 -0000 @@ -512,18 +512,16 @@ out: ip->i_flag |= IN_ACCESS; if (resid > uio->uio_resid && ap->a_cred) { if (ip->i_mode & ISUID) { - error = kauth_authorize_vnode(ap->a_cred, KAUTH_VNODE_RETAIN_SUID, vp, - NULL, EPERM); - if (error) { + if (kauth_authorize_vnode(ap->a_cred, + KAUTH_VNODE_RETAIN_SUID, vp, NULL, EPERM) != 0) { ip->i_mode &= ~ISUID; DIP_ASSIGN(ip, mode, ip->i_mode); } } if (ip->i_mode & ISGID) { - error = kauth_authorize_vnode(ap->a_cred, KAUTH_VNODE_RETAIN_SGID, vp, - NULL, EPERM); - if (error) { + if (kauth_authorize_vnode(ap->a_cred, + KAUTH_VNODE_RETAIN_SGID, vp, NULL, EPERM) != 0) { ip->i_mode &= ~ISGID; DIP_ASSIGN(ip, mode, ip->i_mode); }